From 874eb937dbaa7c02388ed98ca944090f93587f18 Mon Sep 17 00:00:00 2001 From: miigotu <miigotu@gmail.com> Date: Thu, 22 Mar 2018 09:14:55 -0700 Subject: [PATCH] Cast to the correct types and objects for comparison to skip writing out a new tvshow.nfo Fixes #4428 Closes #4429 --- sickbeard/metadata/generic.py | 10 ++-------- sickbeard/tv.py | 4 ---- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/sickbeard/metadata/generic.py b/sickbeard/metadata/generic.py index 884eb36cc..46fffd3a0 100644 --- a/sickbeard/metadata/generic.py +++ b/sickbeard/metadata/generic.py @@ -43,12 +43,6 @@ except ImportError: import xml.etree.ElementTree as etree - - - - - - class GenericMetadata(object): """ Base class for all metadata providers. Default behavior is meant to mostly @@ -283,8 +277,8 @@ class GenericMetadata(object): root = showXML.getroot() if indexerid is not None: - if indexerid == show_obj.indexerid: - return True + if indexerid.text == str(show_obj.indexerid): + return True indexerid.text = str(show_obj.indexerid) else: etree.SubElement(root, "id").text = str(show_obj.indexerid) diff --git a/sickbeard/tv.py b/sickbeard/tv.py index 180fe38b5..3025b4bbe 100644 --- a/sickbeard/tv.py +++ b/sickbeard/tv.py @@ -371,10 +371,6 @@ class TVShow(object): # pylint: disable=too-many-instance-attributes, too-many- logger.log(str(self.indexerid) + ": Show dir doesn't exist, skipping NFO generation") return - self.updateShowNFO() - - def updateShowNFO(self): - result = False if not ek(os.path.isdir, self._location): -- GitLab