From 377aad5402869e4c2632967ff216d1d458dacb7d Mon Sep 17 00:00:00 2001
From: David Boucher <boudav@gmail.com>
Date: Fri, 4 May 2018 10:31:59 +0200
Subject: [PATCH] fix(centAcl.php): Dead code removed (#6262)
* fix(centAcl.php): Dead code removed
The SQL query is simplified a little and all a string affectation
is removed, because done for nothing...
$hostNameCache is no more used.
---
cron/centAcl.php | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/cron/centAcl.php b/cron/centAcl.php
index 098f3d8072..864a69714e 100644
--- a/cron/centAcl.php
+++ b/cron/centAcl.php
@@ -222,8 +222,7 @@ try {
*/
$tabGroups = array();
- $groupStr = "";
- $query = "SELECT DISTINCT acl_groups.acl_group_id, acl_resources.acl_res_id " .
+ $query = "SELECT DISTINCT acl_groups.acl_group_id " .
"FROM acl_res_group_relations, `acl_groups`, `acl_resources` " .
"WHERE acl_groups.acl_group_id = acl_res_group_relations.acl_group_id " .
"AND acl_res_group_relations.acl_res_id = acl_resources.acl_res_id " .
@@ -233,11 +232,7 @@ try {
$DBRESULT1 = $pearDB->query($query);
while ($result = $DBRESULT1->fetchRow()) {
- $tabGroups[$result["acl_group_id"]] = 1;
- if ($groupStr != '') {
- $groupStr .= ",";
- }
- $groupStr = $result["acl_group_id"];
+ $tabGroups[$result['acl_group_id']] = 1;
}
$DBRESULT1->closeCursor();
unset($result);
--
GitLab